L1TopoCoreSim: Fix cppcheck warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.L1TopoCoreSim-20221222 into master

Pass strings by const reference, not by value. Potential null pointer dereference.

Merge request reports