Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 158
    • Merge requests 158
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59756

DerivationFrameworkPHYS: fix tau thinning in PHYSLITE and add DeepSet tau ID to PHYSLITE output

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bertrand Martin Dit Latour requested to merge martindl/athena:master_DFTauFixPhyslite into master Jan 12, 2023
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

Hello,

This MR fixes a problem with tau thinning in PHYSLITE caused by !59677 (merged) : the TauTrackParticleThinning was dropped from the list of thinning tools supported in PhysCommonThinningConfig and replaced with an all-in-one tau thinning tool; this was propagated to the PHYS configuration but not to PHYSLITE.

This MR drops the TauTrackParticleThinning from PHYSLITE and only keeps the new TauThinningTool. It fixes all the PHYSLITE ART tests that are failing today.

Besides, I have added the new Deep Set tau ID to the PHYSLITE output, that's 2 floats (scores) and 4 chars (WPs). The new tau ID was introduced in !59725 (merged) but the output was not kept in PHYSLITE.

For completeness, there is no tau thinning issue in PHYS->PHYSLITE, and the PHYSLITE output seems to be the same (for what concerns taus) when running AOD->PHYSLITE and AOD->PHYS->PHYSLITE.

Unrelated to this MR, I also checked that the multiple tau MRs from yesterday didn't introduce differences in other objects for the PHYS format (I compared today's nightly with yesterday's nightly). I had to ignore tau branches and InDetTrackParticles for this check, as these are affected by tau thinning.

Adding the urgent label. Tagging @calpigia and @jcatmore .

Cheers, Bertrand

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master_DFTauFixPhyslite