Skip to content

Share code between old and new TrackingGeometryBuilder Tools

John Derek Chapman requested to merge jchapman/athena:ShareCodeBetweenTrackingGeometryBuilders_master into master

RobustTrackingGeometryBuilder and StagedTrackingGeometryBuilder are no longer used in reconstruction, so in order to reduce the maintenance burden we attempt to share code with the Cond versions now used in reco. This initial step shares common methods and properties, but does not attempt to share methods which would have to be broken up in order to share code.

RobustTrackingGeometryBuilder.cxx and RobustTrackingGeometryBuilderCond.cxx still contain a lot of repeated code (only ~10 lines out of ~500 differ). Similarly StagedTrackingGeometryBuilder.cxx and StagedTrackingGeometryBuilderCond.cxx still contain a lot of repeated code (only ~20 lines out of ~500 differ). In both cases it will take a bit more thought to factor out the shared code in the cleanest way, so I will leave this to a separate MR.

Tagging @christos.

Edited by John Derek Chapman

Merge request reports