Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59796

cppcheck: Use unsigned int in the byteshift operations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrii Verbytskyi requested to merge averbyts/athena:cppcheck99 into master Jan 13, 2023
  • Overview 19
  • Commits 3
  • Pipelines 2
  • Changes 2

Hi @sutt, please have a look at those changes.

As for me it makes sense to use unsigned for the byte operations --> if does not create an overflow.

Best regards,

Andrii

Tag @sroe

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cppcheck99