Skip to content

Draft: Data Quality - cleanup

Petr Fiedler requested to merge fiedlerp/athena:23.0-dqi-cleanup into 23.0
  • I have removed all unused includes.
  • In header files, I have replaced includes by forward declarations where possible, and moved the includes into the source files.
  • In header files, I have replaced headers with definitions by forward declaring headers where possible, and moved the inclusion of definition into the source files. (<iosfwd>, <nlohmann/json_fwd.hpp>, "CoolKernel/pointers.h")
  • I have made all constructors, destructors, and assignments consistent to avoid memory leaks or double deletion.
  • I have made all copyable object also movable.
  • I have deleted the copy constructors and copy assignment operators for objects whose nature does not allow copying (containing necessary uncopyable data in std::unique_ptr).
  • I have changed HanConfigCompAlg to use default generated Streamer instead of the custom one (which was the same as the generated one).
  • I have replaced hard-to-read types by auto (e.g. template_container<whatever_in_here>::const_interator)
  • At some places, I have changed the hard-to-read for loops with iterators with exact types to the easy-to-understand for-each loops with auto declarations.
  • At some places, I have changed the ROOT TIter while loops to the standard for-each loops.
  • I have changed container inserts to emplaces, where it made sense
  • I have removed typedefs which were not used either as function parameters nor enough times to make it useful.

Merge request reports