Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 173
    • Merge requests 173
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59895

Add MuonFixedLongId to the muon calibration code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Pierre-Francois Giraud requested to merge giraudpf/athena:master-muon-longfixedid into 23.0 Jan 18, 2023
  • Overview 13
  • Commits 5
  • Pipelines 0
  • Changes 10

The MuonFixedId from the muon calibration framework is very useful to define an identifier exportable outside the athena world. (The MuonFixedId is also used in the muon alignment code)

However, the MuonFixedId packs the detector-specific values in a 32-bit payload, using a set of rules that do not leave enough space for the new muon detector technologies MM and sTGC.

This MR introduces a MuonFixedLongId that uses a 64-bit payload, allowing for the new muon detectors. The logic (for the old detector technologies) is identical to that of MuonFixedId, with slightly more space allowed in the packing for each of the detector-specific values.

The validity of the proposed packing is checked using an atlas_test in MuonSpectrometer/MuonCalib/MuonCalibIdentifier/test/MuonFixedLongId_test.cxx

This MR was created on request of @jojungge so that the proposed changes can be reviewed.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-muon-longfixedid