Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 186
    • Merge requests 186
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60069

change handling of JVT in CP algorithms (ATLASG-2447)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nils Erik Krumnack requested to merge krumnack/athena:atlasg_2447 into master Jan 25, 2023
  • Overview 11
  • Commits 4
  • Pipelines 2
  • Changes 4

There was a difference between sequence and block configuration in the nightlies, which caused the test failures in the nightlies. I changed a number of minor things about the jvt configuration:

  • add SuppressInputDependence flag to JetVertexTaggerTool
  • disable runJvtUpdate for the test sequence
  • don't include the JVT selection in the global jet selection, but introduce a selection named JVT.

The last is indeed what fixed the discrepancy, though I'm unsure if this is the right thing to do, or if instead I ought to have a baseline for all jets that includes JVT. I leave that for the jet experts.

Also reordered configuration blocks to match configuration sequences. This is mostly meant to allow easier comparisons of the generated sequence to spot differences more easily.

Edited Jan 25, 2023 by Nils Erik Krumnack
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: atlasg_2447