Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 173
    • Merge requests 173
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60116

TileConditions+TileSimAlgs: Convert TilePulse into conditions object

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Siarhei Harkusha requested to merge harkusha/athena:master-tile-pulse-cond-obj into master Jan 26, 2023
  • Overview 19
  • Commits 3
  • Pipelines 3
  • Changes 10

TilePulse wrapper class around unified TileCalibData conditions object (which knows how to unpack Tile pulse shape from it) has been converted into conditions object itself.

TilePulseShapeCondAlg conditions algorithm which produces TilePulse conditions object has been introduced.

Tile pulse configuration has been updated to use new TilePulseShapeCondAlg algorithm.

Tile digits maker algorithm has been updated to use TilePulse conditions object instead of the corresponding wrapper class.

Tile pulse shape conditions tool has been updated to use TilePulse conditions object.

Unit test for Tile pulse shape conditions tool has been udpated accordingly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-tile-pulse-cond-obj