Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 173
    • Merge requests 173
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60127

Acts+Athena JO: Tracking component configurer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Carlo Varni requested to merge cvarni/athena:TrackingComponentConfigurer into master Jan 26, 2023
  • Overview 9
  • Commits 7
  • Pipelines 3
  • Changes 10

This is a follow-up MR concerning the Tracking Component scheduling (Athena + Acts). A new python class is being introduce to configure the proper algorithm workflow according to the ConfigFlags. The computation is in only one place, and adding additional workflows would be trivial.

The JO simply retrieves booleans from this and schedule the algorithms properly

This is much cleaner than the current implementation in which we have monstrosities such as:

        from InDetConfig.ITkConfigFlags  import TrackingComponent
        useActsSiSpacePointSeedMaker = TrackingComponent.AthenaChain not in flags.ITk.Tracking.recoChain and \
                                       TrackingComponent.ValidateActsClusters not in flags.ITk.Tracking.recoChain and \
                                       (TrackingComponent.ValidateActsSpacePoints in flags.ITk.Tracking.recoChain or \
                                        TrackingComponent.ValidateActsSeeds in flags.ITk.Tracking.recoChain)

A very simple unit test is also added

/cc @jmasik

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: TrackingComponentConfigurer