Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 183
    • Merge requests 183
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60157

Add cluster width as a function of eta plots to IDPVM

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Paul Gessinger-Befurt requested to merge pagessin/athena:idpvm-cluster-width-eta into master Jan 27, 2023
  • Overview 4
  • Commits 2
  • Pipelines 1
  • Changes 4

Actually, this also changes the InDetPerfPlot_HitResidual class to not use raw C arrays for storing histogram pointers, instead using std::vector. I think this is more robust (I have a suspicion that the previous implementation was relying on UB), and I don't think the bounds checking should be relevant in terms of performance.

I'm also adding new (old) plots: cluster eta and phi width as a function of eta for pixel, and phi width only for SCT.

The ITk specific XML file had some references to a previous implementation of this that I couldn't find (maybe 21.9?), which I removed in favor of the central common XML.

/cc @tstreble @lgagnon @ncalace

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: idpvm-cluster-width-eta