Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 175
    • Merge requests 175
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60265

Updated frozen showers library for MC23

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tommaso Lari requested to merge tlari/athena:frozen23v2 into master Feb 01, 2023
  • Overview 14
  • Commits 2
  • Pipelines 3
  • Changes 3

A bug was uncovered by physics validation checks on the first version of the frozen showers library which has been merged in !58896 (merged). @ahrynevi has promptly provided new library files which are fixing the mismodeling at large eta (> 4.5) as illustrated in the attached plot (the current version is the red points, the new one is the green points, the panel is the ratio to G4).

energyVSeta_11_100.0.pdf

Since the current version in master is not good, and since we would like to start MC23 simulation very soon, I am proposing to change the default version in master without waiting for the next physics validation results. I am also marking the MR as urgent. We have discussed this strategy at the physics validation coordination meeting today.

This will change the output of Run 2, Run 3, and Run 4 simulation and will require an update of the reference files.

cheers, Tommaso

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: frozen23v2