Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 169
    • Merge requests 169
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60270

Residual Pull. Use std::array of size 5. Avoid resizing a vector

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:IResidualPullCalculator_actually_opt_method into master Feb 01, 2023
  • Overview 12
  • Commits 2
  • Pipelines 2
  • Changes 10

More or less try to avoid this seen in heaptrack (ATLASRECTS-7471)

MOST TEMPORARY ALLOCATIONS
1875697 temporary allocations of 1875697 allocations in total (100.00%) from:
    std::vector<>::resize(unsigned long)
      at /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/include/c++/11.2.0/bits/stl_vector.h:940
      in /cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2023-01-31T2101/Athena/23.0.15/InstallArea/x86_64-centos7-gcc11-opt/lib/libTrkResidualPullCalculator.so
    Trk::ResidualPullCalculator::residuals(std::vector<>&, Trk::MeasurementBase const*, Trk::ParametersBase<> const*, Trk::ResidualPull::ResidualType, Trk::TrackState::MeasurementType) const
      at /build/atnight/localbuilds/nightlies/Athena/master/athena/Tracking/TrkTools/TrkResidualPullCalculator/src/ResidualPullCalculator.cxx:97

ping @sroe, @amete , @smh

Edited Feb 02, 2023 by Christos Anastopoulos
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: IResidualPullCalculator_actually_opt_method