Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 199
    • Merge requests 199
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60321

TruthSvc logic and debugging updates (ATLASSIM-6361)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:ATLASSIM-6361_23.0.14 into master Feb 02, 2023
  • Overview 8
  • Commits 2
  • Pipelines 2
  • Changes 3

Fix for two bugs in the TruthSvc:

  1. Attempt to access the GenEventBarcodes attribute using the wrong key ("GenEventBarcodes" rather than "barcodes"). This fixes the crash reported in ATLASSIM-6361.
  2. Fix logic for how to update the GenEvent in the case that a particle with a pre-defined decay (i.e. a quasi-stable particle) undergoes an additional non-destructive interaction prior to being decayed. (This was spotted while debugging issue (1).) Unit tests updated for change in call pattern.

These changes will alter the simulation output in principle, but only in the case that the event contains a particle with a pre-defined decay which undergoes an additional non-destructive interaction prior to being decayed. This is quite rare in most samples, so I would not be surprised if the CI tests see no change in output.
Compilation tested for HepMC2 and HepMC3 builds.
Tagging @averbyts, @martindl

Edited Feb 04, 2023 by John Derek Chapman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ATLASSIM-6361_23.0.14