Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60369

Removed intermediate function in MM L1 Simulation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Francesco Giuseppe Gravili requested to merge fgravili/athena:twoINone into master Feb 03, 2023
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

This MR removes a not really needed intermediate function, given the optimization introduced in !60266 (merged) and that the removed function checks are reproducible by simple continue statements. Now the MMT_Road::addHits is much more readable and self-consistent, as all the computation is fully available in a bunch of lines, without having to scroll up and down between the previous two functions.

Changes are also important for ATR-25528

./cc @vadamico

Edited Feb 07, 2023 by Francesco Giuseppe Gravili
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: twoINone