23.0-cleanup-​TRT_SeededTrackFinderTool

Reduce use of dynamically allocated vector: the algorithm only uses the first two points of the spacepoint vector to calculate a new theta, but was allocating a vector of dimension equal to the number of spacepoints. Moved this function to anonymous namespace, as thetaFromSpacePoints.

@christos , relating to general task of reducing dynamic allocations.

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool

This merge request affects 2 files:

• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/TRT_SeededTrackFinderTool/TRT_SeededTrackFinder_ATL.h
• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/src/TRT_SeededTrackFinder_ATL.cxx

Adding @cgrefe ,@calfayan ,@amorley ,@sroe ,@goetz as watchers

added InnerDetector master labels

added Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash b3ae94e8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65666]

added 1 commit

• fd5762dc - revert shortcutting the tan theta

Compare with previous version

resolved all threads

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool

This merge request affects 4 files:

• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/TRT_SeededTrackFinderTool/SiNoise_bt.h
• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/TRT_SeededTrackFinderTool/TRT_SeededTrackFinder_ATL.h
• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/src/SiNoise_bt.cxx
• InnerDetector/InDetRecTools/TRT_SeededTrackFinderTool/src/TRT_SeededTrackFinder_ATL.cxx

Adding @cgrefe ,@calfayan ,@amorley ,@sroe ,@goetz as watchers

CI Result SUCCESS (hash fd5762dc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65670]

removed Run2-MCReco-output-changed label

removed Run3-DataReco-output-changed label

removed Run3-MCReco-output-changed label

marked this merge request as ready

added review-pending-level-1 label

changed the description

added review-approved label and removed review-pending-level-1 label

Looks good to me. Approved.

Cheers L1

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit 993ed76e

merged

added sweep:ignore label