Remove ComponentAccumulator __call__ function

Teng Jian Khoo requested to merge khoo/athena:master-no-CA-call into master

@dguest pointed out that the definition of ComponentAccumulator.__call__ can obscure syntax errors such as calling a CA generator function that is meant to be forwarded to a caller. As this definition

    def __call__(self):
        return self.getPrimary()

is pretty mystifying, we should just use the explicit getPrimary call anywhere this is used.

It is not possible to search the code base for instances of this, so setting full unit+integration tests to see if/where it breaks.

Edited by Teng Jian Khoo

Merge request reports