Draft: Allow the Roi default zed width to be modified

We don't want this to be changed easily all the time - this would be quite fragile so we allow it to be set once and once only.

In principle we would want it to only be setable before any RoiDescriptors are created, which could be done by incrementin s_icount also in the RoiDescriptor::construct() method, but this would require a mutex call to increment the counter for the construction of any RoiDescriptor which would come with a performance penalty so has been missed out. I have a mechanism that could be used to achioeve this with no penalty, but that is for a new request.

This merge request affects 1 package:

• DetectorDescription/RoiDescriptor

This merge request affects 2 files:

• DetectorDescription/RoiDescriptor/RoiDescriptor/RoiDescriptor.h
• DetectorDescription/RoiDescriptor/Root/RoiDescriptor.cxx

Adding @sutt ,@stavrop ,@jojungge ,@apsallid ,@rbianchi as watchers

added Geometry Trigger analysis-review-required master review-pending-level-1 labels

OK from AR viewpoint, approved

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

Many thanks Giovanni, if the CI tests are ok we should be good to go.

Cheers Mark

CI integration tests for projects AnalysisBase are cancelled because of compilation error(s)

CI Result FAILURE (hash 8937e2ed)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 8
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65917]

added 1 commit

• eee7891e - analysis

Compare with previous version

This merge request affects 1 package:

• DetectorDescription/RoiDescriptor

This merge request affects 3 files:

• DetectorDescription/RoiDescriptor/CMakeLists.txt
• DetectorDescription/RoiDescriptor/RoiDescriptor/RoiDescriptor.h
• DetectorDescription/RoiDescriptor/Root/RoiDescriptor.cxx

Adding @sutt ,@stavrop ,@jojungge ,@apsallid ,@rbianchi as watchers

CI Result SUCCESS (hash eee7891e)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 65934]

lgtm

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

added 1 commit

• cb764c1d - AAARGH !!!

Compare with previous version

This merge request affects 2 packages:

• DetectorDescription/RoiDescriptor
• Trigger/TrigSteer/HLTSeeding

Affected files list will not be printed in this case

Adding @sutt ,@tamartin ,@stavrop ,@jojungge ,@apsallid ,@rbielski ,@rbianchi as watchers

added review-pending-level-1 label and removed review-approved review-approved-tier0 labels

changed title from Allow the Roi default zed width to be modified to WIP: Allow the Roi default zed width to be modified

marked this merge request as draft

changed title from WIP: Allow the Roi default zed width to be modified to Draft: Allow the Roi default zed width to be modified