Skip to content

Pad trigger decoding: add try/except in case of unexpected issue

Addresses: ATLASRECTS-7487

I added a try/except in the NSW pad trigger bytestream decoding. This was observed to throw an out-of-range exception in the JIRA ticket when running on the grid and locally.

The decoding logic relies on internal consistency of the data packet. For example, part of the packet tells the user how large a certain block will be; in case the packet is untruthful about the size of this block, an out-of-range exception can occur downstream. This MR resets the data packet in case of an exception, and continues onward.

I sense this is a rare occurrence, since I didn't observe this crash in quite a few tests previously. I haven't checked the untruth of this particular crashing event yet, but I think this is a reasonable behavior in any case. I submit the MR now because I'd rather not continue breaking reconstruction. I'll check for the lie of this particular event in the coming days, and in the unlikely scenario I find something nefarious, I'll report back.

cc @pscholer @jmaurer

Edited by Alexander Naip Tuna

Merge request reports