More detailed debug printout for ActsTrkFinding
More debugging printout, following !60420 (merged). As before, printout is only activated with ConfigFlags.Acts.doPrintTrackStates=True
.
- Split printing from
TrackFindingTool
into new tool,TrackStatePrinter
. -
printMeasurements
usesSpacePoint
position for unmeasured strip coordinates. If that fails (eg. SP is not on surface), uses center. - Show
localToGlobal
andglobalToLocal
comparison for input measurements. IfActs
andTrk
transforms agree, then the printout in those columns is suppressed. - Remove
using ActsTrk::TrackFindingTool::traj_Type = Acts::VectorMultiTrajectory
. It's simpler to specifyActs::VectorMultiTrajectory
explicitly.
Example run:
Reco_tf.py --CA \
--preExec 'flags.Acts.doPrintTrackStates=True;' \
--preInclude InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude,ActsInterop.ActsCIFlags.actsValidateTracksFlags \
--inputRDOFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/PhaseIIUpgrade/RDO/mc15_14TeV.900040.PG_singlemu_Pt100_etaFlatnp0_43.recon.RDO.e8185_s3856_r13824/RDO.29831688._000001.pool.root.1 \
--outputAODFile AOD.pool.root \
--maxEvents 20
The localToGlobal
and globalToLocal
comparison works for everything except for strip discs (search for Annulus
in log.RAWtoALL
). The issue is probably with the Acts
-> Trk
local coordinate transform (localPositionStrip2D
line 309), which I cobbled together by trial and error to be fairly close, but not perfect.
This is a big improvement on what was there before, so I think we should merge this to aid further debugging. Just to be clear, the comparison is only done if ConfigFlags.Acts.doPrintTrackStates=True
and even when it fails, it just shows the mismatched coordinates (no error message).
Merge request reports
Activity
added ACTS label
added 1 commit
- 6887f665 - compare center and normal for measurement detectorElements
added 1 commit
- 2e14f1a2 - show all measurement surfaces and compare ACTS to Athena
added 5 commits
- 7875841e - first go at matching detector elements by center
- f1a68ebd - fix crash due to reallocated vector data
- 65cb85c3 - use surface matching in ActsATLASConverterTool. Tidy up printout in TrackFindingTool.
- 7427e1c6 - Add reverse mapping, but gives warnings about multiple surfaces. remove printSurfaces.
- 3bbef055 - remove reverse match for the moment
Toggle commit listadded 781 commits
-
3bbef055...0b2e1775 - 780 commits from branch
atlas:master
- 93e0bd24 - printMeasurements uses SpacePoint position for unmeasured strip coordinates....
-
3bbef055...0b2e1775 - 780 commits from branch
added 1 commit
- 3c98f196 - print short explanation at top of first table
added 1 commit
- 00993fdc - Separate strip Trk and Acts loc. Trk uses PRD localPosition. This uses code from an earlier commit.
added 365 commits
-
00993fdc...d7acf7a2 - 360 commits from branch
atlas:master
- a0a1354f - printMeasurements uses SpacePoint position for unmeasured strip coordinates....
- 599f039a - remove unused component
- 0e54bdf2 - print short explanation at top of first table
- 1ff145ce - Separate strip Trk and Acts loc. Trk uses PRD localPosition. This uses code from an earlier commit.
- 55a55922 - ActsTrk::SpacePoint -> xAOD::SpacePoint*
Toggle commit list-
00993fdc...d7acf7a2 - 360 commits from branch
added 1 commit
- c381554c - simplify localPositionStrip2D. Remove some unused includes.
added 1 commit
- b65a5f46 - remove unneeded includes. Increase width of GeometryId
- Resolved by Tim Adye
Hello,
following the creation of the 23.0 branch from master, you should now decide whether this MR should target 23.0 or master, according to these guidelines agreed in the Software Weekly meeting:
https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf
If you decide that this MR should target 23.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 23.0 will also be swept into master.
Thanks!
James & Nick
added 2 commits
added 717 commits
-
930b4d93...b8ae0312 - 716 commits from branch
atlas:master
- 67157f21 - Split printing from TrackFindingTool into TrackStatePrinter. printMeasurements...
-
930b4d93...b8ae0312 - 716 commits from branch
added 1 commit
- c4113b77 - better Acts->Trk transform for strip disc check - still not perfect