Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60888

Improve consistency between jet trigger CA and legacy config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Teng Jian Khoo requested to merge khoo/athena:master-trigjetCA-consistency into 23.0 Feb 20, 2023
  • Overview 39
  • Commits 15
  • Pipelines 11
  • Changes 12

@cantel, @lbeemste, @jburr

Making progress erasing naming differences between the CA and legacy configs for jet chains

Notable changes:

  • I put the jetDefStr into the jetRecoDict now, to make it easier to retrieve all over the code, without having to keep calling the function to construct it. The string is filled in on extraction of the dict from the chainParts.
  • To help with keeping the name correct, I also added a copy-and-update function for the jetRecoDict used in e.g. grooming and reclustering workflows
  • The JetViewAlg config is unified via the CA function + wrapper.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-trigjetCA-consistency