Skip to content

Fix ITkStrip barrel modules in ACTS tracking geometry

Paul Gessinger requested to merge pagessin/athena:acts-trk-geo-fix into master

This MR fixes a bug in the way the strip barrel rows were constructed. The SI design provides a module shift that needs to be applied before reco-to-hit transformation, but was applied after. The code is changed to retain compatibility in the ordering for the ITk strip endcap modules.

This MR also adds a consistency check to the ACTS tracking geometry service, that will optionally do a statistical compatibility check between the Acts:: and Trk:: surfaces. It throws random points on the ACTS surface, converts them to the local Trk surfaces and then checks if both or neither of the surfaces reports the point to be inside it's bounds. This works for both planar and disc surfaces (=Annulus).

I changed the ActsITkTest.py to run this consistency check. It takes a few seconds to run, but might be fast enough for CI anyway.

/cc @ncalace @adye

Merge request reports