Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60961

AsgComponentConfig Re-Design, 21.2 branch (2023.02.23.)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Attila Krasznahorkay requested to merge akraszna/athena:AsgComponentConfigRedesign-21.2-20230222 into 21.2 Feb 23, 2023
  • Overview 9
  • Commits 1
  • Pipelines 1
  • Changes 7

This is a manual cherry-pick (with some changes) from !60899 (merged). A more detailed description of the problem solved (and also described in ATLASG-2456) is in that ticket.

@krumnack, I found it curious how this 21.2 branch uses JobOptionsSvc differently from the master branch. What surprised me most is that this branch, naively, seems to do a better job. 😕 Could you clarify what's going on?

At the same time I enabled the same two unit tests for AnalysisBase that the package now uses in master as well. 😉

This is not strictly necessary for 21.2 as far as I understand. The same dictionary issue that hits us in master is not present with the ROOT version used in this branch. But it may still be a good idea not to let the two branches diverge on this. 🤔

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: AsgComponentConfigRedesign-21.2-20230222