Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- Add "BunchCrossingTime" and "PileUpType"
Attributes
toGenEvent
objects during pile-up digitization / presampling (HepMC3 only). These provide an alternative to the currentMcEventCollection
structure-based approach ofGenEvent
event classification used when pile-up truth is written out. - Update client code to propagate/make use of these properties.
- Update
SimpleMergeMcEventCollTool
to be able to optionally override the event numbers in the same way asMergeMcEventCollTool
. - Switch HepMC3-based builds to use
SimpleMergeMcEventCollTool
instead ofMergeMcEventCollTool
. This drops the complicatedMcEventCollection
structure, but should be transparent to reconstruction output.
Relates to ATLSWUPGR-167.
Merge request reports
Activity
- Resolved by John Derek Chapman
Hello,
following the creation of the 23.0 branch from master, you should now decide whether this MR should target 23.0 or master, according to these guidelines agreed in the Software Weekly meeting:
https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf
If you decide that this MR should target 23.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 23.0 will also be swept into master.
Thanks!
James & Nick
added 727 commits
-
b3c5e145...88cc54b9 - 725 commits from branch
atlas:master
- 88b3ae3a - Update README.md accounting for new release numbering
- 255ab64d - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
-
b3c5e145...88cc54b9 - 725 commits from branch
added 1257 commits
-
255ab64d...3773fb76 - 1255 commits from branch
atlas:23.0
- 9bad35f7 - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 9e4693cf - xAODTruthCnvAlg update
-
255ab64d...3773fb76 - 1255 commits from branch
added 114 commits
-
9e4693cf...7aa68003 - 111 commits from branch
atlas:23.0
- 3eaabd21 - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 022c8750 - xAODTruthCnvAlg update
- 90ffe08e - Bugfix Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p6.cxx
Toggle commit list-
9e4693cf...7aa68003 - 111 commits from branch
added 1 commit
- 82b04930 - SimpleMergeMcEventCollTool: Adapt to work with standard presampling workflow
added 94 commits
-
82b04930...3672a068 - 89 commits from branch
atlas:23.0
- 341d773d - Bugfix Generators/GeneratorObjectsTPCnv/src/McEventCollectionCnv_p6.cxx
- 66e6554a - Extend McEventCollectionCnv_p6_test to cover setting GenEvent attributes
- 115fe679 - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 2402a96f - xAODTruthCnvAlg update
- 093f7628 - SimpleMergeMcEventCollTool: Adapt to work with standard presampling workflow
Toggle commit list-
82b04930...3672a068 - 89 commits from branch
added 301 commits
-
093f7628...7a812c21 - 296 commits from branch
atlas:23.0
- 5772c45a - xAODTruthCnvAlg update
- 6036c568 - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 07ddaa96 - SimpleMergeMcEventCollTool: Adapt to work with standard presampling workflow
- 4405f185 - Force use of SimpleMergeMcEventCollTool in CA jobs
- 3c3a2bf8 - Debugging lines
Toggle commit list-
093f7628...7a812c21 - 296 commits from branch
added 958 commits
-
61f0a0ea...a3882ae2 - 954 commits from branch
atlas:23.0
- 487c6def - xAODTruthCnvAlg update
- 43f812bb - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 53404858 - SimpleMergeMcEventCollTool: Adapt to work with standard presampling workflow
- 5c5d8a42 - Force use of SimpleMergeMcEventCollTool in CA jobs
Toggle commit list-
61f0a0ea...a3882ae2 - 954 commits from branch
added 231 commits
-
5c5d8a42...14c14189 - 227 commits from branch
atlas:23.0
- 083bfa16 - xAODTruthCnvAlg update
- 79c7b495 - Adding BunchCrossingTime and PileUpType Attributes to GenEvents during pile-up digitization
- 4ab47812 - SimpleMergeMcEventCollTool: Adapt to work with standard presampling workflow
- 5c170360 - Force use of SimpleMergeMcEventCollTool in CA jobs
Toggle commit list-
5c5d8a42...14c14189 - 227 commits from branch
- Resolved by John Derek Chapman
Just such that we don't forget, we will also need to update the following file
with
if(!m_usePUHits && deposit.first.eventIndex()!=0)
Cheers, Thomas
added 4 commits
Toggle commit listadded 1 commit
- 97eef5f7 - Update TruthClusterizationFactory to work with new structure
- Resolved by John Derek Chapman