Skip to content

ISF_FastCaloSimEvent: A few optimizations to improve FastCaloGAN processing by 2 orders of magnitude

Alaettin Serhan Mete requested to merge amete/athena:master-fastcalogan-opt into master

This MR includes a few optimization to ISF_FastCaloSimEvent. The performance of the test job w/ 10 events changes from:

INFO ***************************************************************************************
INFO Number of events processed:        10  
INFO CPU usage per event [ms]:          717647
INFO Events per second:                 0.002
INFO CPU utilization efficiency [%]:    17  
INFO ***************************************************************************************

to:

INFO ***************************************************************************************
INFO Number of events processed:        10  
INFO CPU usage per event [ms]:          20927
INFO Events per second:                 0.174
INFO CPU utilization efficiency [%]:    87  
INFO ***************************************************************************************

i.e. the event-loop takes 1 minute instead of 1.5 hours.

I also commented out some verbose std::cout messages. I kept them around so that developers can properly migrate them to the standard logging in the future.

It would be good to review this code at large to make sure we avoid unnecessary creation/deletion of ROOT objects which can be very costly due to both unnecessary memory operations and lock contention.

cc: @jchapman

Edited by Alaettin Serhan Mete

Merge request reports