MET TST Systematics Pre-Recs

This MR updates the default paths of the METSystematicTool to point to the ones of the R22 pre-recommendations. In addition, two adjustments from R21 are propagated:

1. adding a protection for events where no object is added to the MET calculation and the MET consistent of only the soft term
2. adjust the MET TST systematic name to the __1up and __1down scheme

Tagging @hpacey, @aoneill & @gotero.

This merge request affects 2 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

added JetEtmiss Reconstruction analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash feed7274)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67899]

The Athena CITest_TriggerMC-test failure is unrelated but the AnalysisBase and AthAnalysis have failures with METUtilities_gt_metSystematicsTool_ctest. Can you please investigate? Thanks

Best, Thomas - L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 1ab2ebca - adjusting METSystTool unit test

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/MET/METInterface
• Reconstruction/MET/METUtilities

Affected files list will not be printed in this case

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

Hi @tstreble, there was a problem with the paths to the calibration file. That should be fixed now.

CI Result SUCCESS (hash 1ab2ebca)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 67945]

Looks good. L1

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

added analysis-review-approved label and removed analysis-review-required label

added review-approved-point1 label

Hello,

following the creation of the 23.0 branch from master, you should now decide whether this MR should target 23.0 or master, according to these guidelines agreed in the Software Weekly meeting:

https://indico.cern.ch/event/1266042/attachments/2613269/4515725/branching_guidelines.pdf

If you decide that this MR should target 23.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 23.0 will also be swept into master.

Thanks!

James & Nick

resolved all threads

merged

mentioned in commit e93dc014

added sweep:ignore label