Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 148
    • Merge requests 148
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !61685

Solving circular dependency and clean up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sergi Rodriguez Bosca requested to merge serodrig/athena:FixWarning into 23.0 Mar 20, 2023
  • Overview 13
  • Commits 2
  • Pipelines 2
  • Changes 8

This MR is meant to solve one circular dependency found, and reported here: ATR-22275

To solve the circular dependency, I have disentangled the jTower creation from the simulation. This will allow a future MR where we will be able to send jFEX input data as input of the simulation.

Additionally some clean up have been made.

Edited Mar 22, 2023 by Sergi Rodriguez Bosca
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: FixWarning