Skip to content
Snippets Groups Projects

[FTAG] add flipped GNN taggers to output and fix flipping logic

Merged Philipp Gadow requested to merge pgadow/athena:athena-yinmiao_branch into 23.0

This MR modifies the flipped tagger logic for all GNN flavour tagging algorithms. It further adds the flipped GN1 and GN2 scores to the output in derivations, so that studies of the flipped taggers become possible.

This MR is taking the changes which @yinmiao introduced in !61905 (closed) and targets 23.0 (and not master). We decided to open a new MR to have it cleaner.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS (hash 6e0489ef)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 68936]

  • Philipp Gadow mentioned in merge request !61905 (closed)

    mentioned in merge request !61905 (closed)

  • Dan Guest
  • Dan Guest
  • I was thinking about this and realized we could take the safe option and enable a few variants very easily. If this is getting to be more than you wanted to deal with right now you can also just ignore my comments and mark this as urgent, and maybe I'll implement what I suggested above later.

    The one point that worries me slightly is the naming convention: we should not put in the wrong name for the variable now if we're likely to change it later.

  • Setting review-user-action-required while open threads are being addressed

  • Philipp Gadow added 1 commit

    added 1 commit

    • bf506d7a - schedule both negative sign and flip schemes for GN1+GN2 flipped taggers

    Compare with previous version

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

    Affected files list will not be printed in this case

    Adding @nishu ,@rcreager ,@duperrin ,@sanmay ,@jcatmore ,@calpigia ,@dguest ,@bdong ,@lidiaz as watchers

  • Philipp Gadow added 1 commit

    added 1 commit

    • 831cc137 - add negative ip and flip tagger outputs for GN1 to BTaggingContent

    Compare with previous version

  • Philipp Gadow resolved all threads

    resolved all threads

  • Dan Guest resolved all threads

    resolved all threads

  • Dan Guest resolved all threads

    resolved all threads

  • Dan Guest resolved all threads

    resolved all threads

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

    Affected files list will not be printed in this case

    Adding @nishu ,@rcreager ,@duperrin ,@sanmay ,@jcatmore ,@calpigia ,@dguest ,@bdong ,@lidiaz as watchers

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading