Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !61977

fix a bug where the muon punch through simulation overestimate the number of punch-through particles

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tong Qiu requested to merge tqiu/athena:tong-mptbugfix into 23.0 Mar 30, 2023
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 1

The code uses lround to convert floats into integers when sampling from the CDF for the distribution of the number of punch-through particles. The float number describes the number of punch-through particles. A value between 0-1 should mean zero particles. Using lround will give us a 50% probability of having one particle when the number is between 0 to 1, so the simulation gives us more particles than expected.

The fix use int to select the integer closer to zero.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tong-mptbugfix