Skip to content
Snippets Groups Projects

Fast Chain: Fixes for running simulation and pile-up digitization in a single job

Merged John Derek Chapman requested to merge jchapman/athena:FastChainFixes_Pt2_23.0 into 23.0
All threads resolved!

Update FastChainPileup ART jobs running simulation + pile-up digitization in a single job to correctly set the conditions IoVs.

Fix for preInclude/preExec in Legacy configuration for Fast Chain with pile-up digitization.

Switch off BCM Digitization/Overlay if using Fatras for Inner Detector simulation as Fatras does not simulate the BCM. (Also affects Fast Chain jobs running Overlay in principle.)

Ensure that the TRT Tracking Geometry is built the same way in legacy and CA-based configuration when running Fatras.

Also rename a couple of components, so that the names agree between legacy and CA-based configuration to remove some noise from configuration diffs.

Tagging @pagacova.

Merge request reports

Pipeline #5360277 passed

Pipeline passed for b382767a on jchapman:FastChainFixes_Pt2_23.0

Approval is optional

Merged by Marija Vranjes MilosavljevicMarija Vranjes Milosavljevic 1 year ago (Apr 3, 2023 8:55am UTC)

Merge details

  • Changes merged into 23.0 with e5953bdf (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS (hash 54e37e3a)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69031]

  • added 7 commits

    • 8f2ad19d - ATR-27151 Fix AOD->NTUP_TRIGRATE: FPE DIVBYZERO
    • 78deae65 - Attempt to switch off BCM in Fast Chain jobs with Fatras
    • b81bd3ab - Legacy config build detailed TRT Tracking geometry for Fatras jobs
    • b7f725c0 - SCT_Digitization: Update tool names used to match between CA-based and legacy configuration.
    • 6dbc6588 - Tweak for legacy configuration of TRT_PAI_Process_Xe tool
    • 99cd257e - Fast Chain: Fixes for running simulation and pile-up digitization in a single job (WIP)
    • b382767a - FastChain: Legacy pile-up configuration should copy PileUpTruthParticles if present

    Compare with previous version

  • John Derek Chapman resolved all threads

    resolved all threads

  • This merge request affects 7 packages:

    • InnerDetector/InDetConditions/SiPropertiesTool
    • InnerDetector/InDetDigitization/SCT_Digitization
    • InnerDetector/InDetSimUtils/TRT_PAI_Process
    • Simulation/FastSimulation/FastChainPileup
    • Simulation/ISF/ISF_Config
    • Tools/FullChainTransforms
    • Trigger/TrigCost/RatesAnalysis

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@tadej ,@ahaas ,@aporeba ,@calfayan ,@tamartin ,@tkharlam ,@sroe ,@cgrefe as watchers

  • added Trigger label

  • :white_check_mark: CI Result SUCCESS (hash b382767a)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69063]

  • lgtm

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit e5953bdf

  • Walter Lampl mentioned in merge request !62063 (merged)

    mentioned in merge request !62063 (merged)

  • Please register or sign in to reply
    Loading