Skip to content
Snippets Groups Projects

Add optional ML based e/p workflow

Merged Add optional ML based e/p workflow
atlas-particleflow-software/athena:pflow_NN into 23.0
All threads resolved!
Merged Mark Hodgkinson requested to merge atlas-particleflow-software/athena:pflow_NN into 23.0
All threads resolved!

This adds an optional workflow, not to be used in production, that predicts the e/p for a track using a ML model. The main changes are the addition of a new tool, PFEnergyPredictorTool written by @abarton , along with associated toggles to enable usage of this via a python flag. I tested on 2000 ttbar events that the output looks the same with physics validation. RunWorkFlowTests_run3.py indicated no frozen violating tier0 changes. The above is as expected, given this workflow is not enabled by default.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Hodgkinson marked this merge request as draft

    marked this merge request as draft

  • Mark Hodgkinson added 1 commit

    added 1 commit

    Compare with previous version

  • Mark Hodgkinson resolved all threads

    resolved all threads

  • Mark Hodgkinson marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Reconstruction/eflowRec

    This merge request affects 13 files:

    • Reconstruction/eflowRec/CMakeLists.txt
    • Reconstruction/eflowRec/eflowRec/PFEnergyPredictorTool.h
    • Reconstruction/eflowRec/eflowRec/PFSubtractionTool.h
    • Reconstruction/eflowRec/eflowRec/eflowCaloObject.h
    • Reconstruction/eflowRec/eflowRec/eflowTrackCaloPoints.h
    • Reconstruction/eflowRec/python/PFCfg.py
    • Reconstruction/eflowRec/python/PFConfigFlags.py
    • Reconstruction/eflowRec/src/PFEnergyPredictorTool.cxx
    • Reconstruction/eflowRec/src/PFSubtractionTool.cxx
    • Reconstruction/eflowRec/src/components/eflowRec_entries.cxx
    • Reconstruction/eflowRec/src/eflowCaloObject.cxx
    • Reconstruction/eflowRec/src/eflowTrackCaloExtensionTool.cxx
    • Reconstruction/eflowRec/src/eflowTrackCaloPoints.cxx

    Adding @goetz ,@mhodgkin ,@cantel as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f51f7e6f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69053]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8bb67a79)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69064]

  • David Rousseau added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Marija Vranjes Milosavljevic added review-approved-point1 label

    added review-approved-point1 label

  • Julien Maurer added review-approved-tier0 label

    added review-approved-tier0 label

  • Julien Maurer mentioned in commit f5846db7

    mentioned in commit f5846db7

  • Julien Maurer merged

    merged

  • Walter Lampl mentioned in merge request !62109 (merged)

    mentioned in merge request !62109 (merged)

    • Please register or sign in to reply