Skip to content

TrigValidation: use CA in RAWtoALL, fix broken tests

Bertrand Martin Dit Latourrequested to merge
martindl/athena:23.0_TrigNavBug into 23.0

Hello,

The primary goal of this MR is to use the ComponentAccumulator in the RAWtoALL step of trigger ART tests.

The main changes are:

  • add --CA "default:True" "RDOtoRDOTrigger:False" for RDO->AOD MC tests, to run CA for RAWtoALL
  • drop doTRIGtoALL from the steering, as RAWtoALL is now the default behaviour for offline reconstruction
  • drop from AthenaConfiguration.AllConfigFlags import ConfigFlags from preExec, such that we can use the same preExec for RDOtoRDOTrigger and RAWtoALL (from AthenaConfiguration.AllConfigFlags import ConfigFlags is now forbidden in RAWtoALL)
  • legacy flags are replaced with ConfigFlags
  • ConfigFlags.Trigger.enableL1CaloPhase1=False is set for tests running over old RDO inputs that don't have supercells

Fixes ATR-27224, ATR-27092, ATR-27107, ATR-27226.

Cheers, Bertrand

Edited by Bertrand Martin Dit Latour

Merge request reports