DetDescSvc - Some clean up
DetDescrCnvSvc
:
- Use ATH_MSG messaging macros
- Add switches to toggle all muon sub detectors seperately
- Useage of ATH_CHECK macros
DetDescrConverter
:
- Remove commented code
IdDictDetDescrCnv
:
- Inherit from
AthMessaging
- Factor common structures into seperate methods
MuonIdHelperSvc
:
- Toggle the remaining subdetectors from the description
Tagging: @tadej
Merge request reports
Activity
This merge request affects 4 packages:
- DetectorDescription/DetDescrCnvSvc
- DetectorDescription/IdDictDetDescrCnv
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonIdHelpers
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer ,@rbianchi as watchers
added Geometry MuonSpectrometer master review-pending-level-1 labels
added full-unit-tests label and removed Geometry MuonSpectrometer master review-pending-level-1 labels
This merge request affects 4 packages:
- DetectorDescription/DetDescrCnvSvc
- DetectorDescription/IdDictDetDescrCnv
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonIdHelpers
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer ,@rbianchi as watchers
added Geometry MuonSpectrometer master review-pending-level-1 labels
added 1 commit
- 51401bdf - Insert primary helper instead of mdt simplify HPTDC
This merge request affects 4 packages:
- DetectorDescription/DetDescrCnvSvc
- DetectorDescription/IdDictDetDescrCnv
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonIdHelpers
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer ,@rbianchi as watchers
❌ CI Result FAILURE (hash 8d9bc7df)Athena AthSimulation AthGeneration externals ✅ ✅ ✅ cmake ✅ ✅ ✅ make ✅ ✅ ✅ tests ⭕ ⭕ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69215]❌ CI Result FAILURE (hash 81ee9d76)Athena AthSimulation AthGeneration externals ✅ ✅ ✅ cmake ✅ ✅ ✅ make ✅ ✅ ✅ tests ⭕ ⭕ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69221]❌ CI Result FAILURE (hash 51401bdf)Athena AthSimulation AthGeneration externals ✅ ✅ ✅ cmake ✅ ✅ ✅ make ✅ ✅ ✅ tests ⭕ ⭕ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69225]- Resolved by Johannes Junggeburth
This merge request affects 4 packages:
- DetectorDescription/DetDescrCnvSvc
- DetectorDescription/IdDictDetDescrCnv
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonIdHelpers
Affected files list will not be printed in this case
Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer ,@rbianchi as watchers