Bug fix to particle flow thinning code

As discussed here:


a bug was found by @markovit whereby the thinning of neutral particle flow objects had not taken place.

Running a data22 test in the latest 23.0 I confirmed this was the case and confirmed that the fix in this MR solves the issue. Thus this MR violates FT0V because it removes neutral particle flow FlowElement with energy < 0 from the AOD.

If we have already produced AOD that will be used in conjunction with future AOD, care might be needed because the jets would presumably also change (assuming the jet finding software does not apply its own cut that input objects should have energy >= 0 - perhaps @delsart knows?). Flagging to @mswiatlo ,@schaarsc ,@camacho ,@mleblanc



Merge request reports