Raise an AttributeError for __getattr__ methods in AthConfigFlags (!62173) · Merge requests · atlas / athena

Jon Burr requested to merge jburr/athena:ATEAM-898 into master Apr 06, 2023

@amete noted that the existing approach of raising RuntimeError (FlagAddress) or just blindly creating a FlagAddress object (AthConfigFlags) breaks the use of getattr. It also violates basic python rules...

This unifies the logic between the two implementations and ensures that an AttributeError is raised as required by python.

I guess this should also go into 23.0, but I'm not sure how to do that. Is it better to cherry-pick the commit or open an MR to 23.0 and then have it swept to master?

Raise an AttributeError for __getattr__ methods in AthConfigFlags

Merge request reports

Raise an AttributeError for getattr methods in AthConfigFlags