Skip to content
Snippets Groups Projects

AnalysisTop: Fix list of SFs for muon breakdown

Merged Tomas Dado requested to merge tdado/athena:AnalysisTop-MuonSFfix into master
All threads resolved!

After the recent recommendations update, a new SF systematic variation has been added for low pT muons when using the more complex breakdown. Need to update the code to retrieve it properly

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomas Dado added 1 commit
  • Tomas Dado resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/TopPhys/xAOD/TopCorrections

    This merge request affects 2 files:

    • PhysicsAnalysis/TopPhys/xAOD/TopCorrections/Root/MuonScaleFactorCalculator.cxx
    • PhysicsAnalysis/TopPhys/xAOD/TopCorrections/TopCorrections/MuonScaleFactorCalculator.h

    Adding @skorn ,@cgarvey ,@ravinab ,@thsteven as watchers

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • :white_check_mark: CI Result SUCCESS (hash 7900696c)

    AnalysisBase
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69988]

  • OK from AR viewpoint

    Giovanni (AR)

  • The changes look okay and there are no CI issues. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 341b2274

  • Please register or sign in to reply
    Loading