Add Test for checking log levels and fix bug related to conversion Acts -> Gaudi and Gaudi -> Acts
Bug in conversion of log levels between Acts and Gaudi. Added unit test to verify a consistent translation
Merge request reports
Activity
This merge request affects 1 package:
- Tracking/Acts/ActsInterop
This merge request affects 5 files:
- Tracking/Acts/ActsInterop/ActsInterop/Logger.h
- Tracking/Acts/ActsInterop/CMakeLists.txt
- Tracking/Acts/ActsInterop/share/ActsLogger.ref
- Tracking/Acts/ActsInterop/src/Logger.cxx
- Tracking/Acts/ActsInterop/test/LoggerTest.cxx
Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers
added Tracking master review-pending-level-1 labels
removed review-pending-level-1 label
CI Result SUCCESS (hash 14018c72) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70653] This merge request affects 1 package:
- Tracking/Acts/ActsInterop
This merge request affects 5 files:
- Tracking/Acts/ActsInterop/ActsInterop/Logger.h
- Tracking/Acts/ActsInterop/ActsInterop/LoggerUtils.h
- Tracking/Acts/ActsInterop/CMakeLists.txt
- Tracking/Acts/ActsInterop/src/Logger.cxx
- Tracking/Acts/ActsInterop/test/LoggerTest.cxx
Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers
added review-pending-level-1 label
CI Result SUCCESS (hash 30f71c69) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70660] This merge request affects 1 package:
- Tracking/Acts/ActsInterop
This merge request affects 5 files:
- Tracking/Acts/ActsInterop/ActsInterop/Logger.h
- Tracking/Acts/ActsInterop/ActsInterop/LoggerUtils.h
- Tracking/Acts/ActsInterop/CMakeLists.txt
- Tracking/Acts/ActsInterop/src/Logger.cxx
- Tracking/Acts/ActsInterop/test/LoggerTest.cxx
Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers
CI Result SUCCESS (hash 81657152) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70671] added 36 commits
- e42fd081 - ActsTrkFittingTools: added GSF refitting code (inspired from KF refitting)
- 458930ad - ActsTrkFittingAlgs: added GSF config
- 1229dbc5 - ActsTrkFittingAlgs: added function to convert to xAOD and output to ESD/AOD...
- 0ccf60ad - ActsTrkFittingTools GSF: fix TrackFitter type
- 442507dc - Merge remote-tracking branch 'upstream/master' into acts-gsf-refitting
- 53e8b1de - ActsTrkFittingTools: transfered code from .ipp to .cxx & created a common file of helper functions
- df528da1 - ActsTrkFittingTools: Removed unnecessary members
- 6c544db4 - ActsTrkFittingTools: adjusted message output level
- 5fe4b159 - Combined two ACTS refitting Python cfg into one & added a flag to choose ACTS fitter
- 5c71e1b4 - ActsTrkFittingAlgs: fixed issue with dealing with nullptr
- e707714f - Shorter way of defining a list
- cba8e6c5 - Introduced specific namespace for HelperFunctions & code clean-up (comments etc)
- 882aa39a - Update the syntax of member initializations
- 6927b665 - Use default destructor
- 2f6ffe5f - Remove unneeded include
- 8837d193 - Using C++ extends functionnality
- 91c0b825 - Merge branch 'upstream/master' into acts-gsf-refitting
- 8be4f8fb - Adapt to ACTS v21.1.0 changes
- b59f8842 - Check msgLvl before printing warnings
- bce401b2 - Merge remote-tracking branch 'upstream/master' into acts-gsf-refitting
- 0114239b - Updated the KalmanFitter code
- ccc58824 - Disable abort on error for GSF refit
- 3f6e0314 - Implement enum for ACTS fitter choice via flag
- 0ff0b46c - More consistent indentation
- 7fe19b61 - More consistent indentation
- 6a746eed - Reusing the input name argument in python config
- 9766c140 - Remove unnecessary ValueError
- 60bb9938 - Applied suggestions from Thomas Strebler
- 6348d46d - Merge remote-tracking branch 'upstream/master' into GSF_TEST
- 374b2dbe - Add CI test for GSF ACTS
- b157df88 - sync
- e116b86f - sync
- 24ff7567 - Merge remote-tracking branch 'origin/GSF_TEST' into GSF_TEST
- dba474ad - minor changes
- c0334672 - Merge remote-tracking branch 'origin/GSF_TEST' into ActsLoggerTest
- a40a4c0e - add entries in array
Toggle commit listadded Test analysis-review-required labels
This merge request affects 1 package:
- Tracking/Acts/ActsInterop
This merge request affects 5 files:
- Tracking/Acts/ActsInterop/ActsInterop/Logger.h
- Tracking/Acts/ActsInterop/ActsInterop/LoggerUtils.h
- Tracking/Acts/ActsInterop/CMakeLists.txt
- Tracking/Acts/ActsInterop/src/Logger.cxx
- Tracking/Acts/ActsInterop/test/LoggerTest.cxx
Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers
Since this adds a unit test, this MR relates to ATLIDTRKCP-436 as well
CI Result SUCCESS (hash eb6ad067) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70694] - Resolved by Carlo Varni
- Resolved by Carlo Varni
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 1 package:
- Tracking/Acts/ActsInterop
This merge request affects 5 files:
- Tracking/Acts/ActsInterop/ActsInterop/Logger.h
- Tracking/Acts/ActsInterop/ActsInterop/LoggerUtils.h
- Tracking/Acts/ActsInterop/CMakeLists.txt
- Tracking/Acts/ActsInterop/src/Logger.cxx
- Tracking/Acts/ActsInterop/test/LoggerTest.cxx
Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILURE (hash a40a4c0e) Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70693] The build failure in
AthAnalysis
is not related and should be fixed with !62731 (merged) (see ATLSUSYBGF-663).The failure in
ACTS_ActsGSFRefitting-test
doesn't appear to be related either but I've not seen it elsewhere yet. @armaury @pagessin @lgagnon any idea about why it happens?- Resolved by Thomas Strebler
@tstreble this CI result is from a previous commit (no idea why it took so long). The GSF test is something I added by mistake during my local testing.
CI Result SUCCESS (hash 88ac1380) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70711] added review-approved label and removed review-pending-level-1 label
added analysis-review-approved label and removed analysis-review-required label
mentioned in commit c28d49c6
added sweep:ignore label