Skip to content
Snippets Groups Projects

Add Test for checking log levels and fix bug related to conversion Acts -> Gaudi and Gaudi -> Acts

Merged Carlo Varni requested to merge cvarni/athena:ActsLoggerTest into master
All threads resolved!

Bug in conversion of log levels between Acts and Gaudi. Added unit test to verify a consistent translation

Merge request reports

Pipeline #5495540 passed

Pipeline passed for 88ac1380 on cvarni:ActsLoggerTest

Merged by Edward MoyseEdward Moyse 1 year ago (Apr 28, 2023 2:44pm UTC)

Merge details

  • Changes merged into with c28d49c6.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just a minor style comment.

    Best, Thomas - L1

  • Carlo Varni added 1 commit

    added 1 commit

    Compare with previous version

  • Carlo Varni resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Tracking/Acts/ActsInterop

    This merge request affects 5 files:

    • Tracking/Acts/ActsInterop/ActsInterop/Logger.h
    • Tracking/Acts/ActsInterop/ActsInterop/LoggerUtils.h
    • Tracking/Acts/ActsInterop/CMakeLists.txt
    • Tracking/Acts/ActsInterop/src/Logger.cxx
    • Tracking/Acts/ActsInterop/test/LoggerTest.cxx

    Adding @tbold ,@amorley ,@toyamaza ,@cvarni ,@pagessin as watchers

  • :pencil: :scissors: CI integration tests for projects AthAnalysis are cancelled because of compilation error(s)

  • :x: CI Result FAILURE (hash a40a4c0e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :o: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :o: AthAnalysis: number of compilation errors 1, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70693]

  • The build failure in AthAnalysis is not related and should be fixed with !62731 (merged) (see ATLSUSYBGF-663).

    The failure in ACTS_ActsGSFRefitting-test doesn't appear to be related either but I've not seen it elsewhere yet. @armaury @pagessin @lgagnon any idea about why it happens?

  • Author Developer

    we are still waiting for the correct pipeline to finish

  • Thomas Strebler resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 88ac1380)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 70711]

  • Looks good, approving - L1

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit c28d49c6

    mentioned in commit c28d49c6

  • Please register or sign in to reply
    Loading