eflowRec: Fix cppcheck warnings.

Pass strings/containers by const reference, not by value. Prefer preincrement to postincrement for iterator classes. Prefer to initialize class members in an initialization list.