ISF_FastCaloSimEvent: Fix cppcheck warnings.

Merged Scott Snyder requested to merge ssnyder/athena:cppcheck.ISF_FastCaloSimEvent-20230520 into 23.0

Avoid unneeded copies of containers. Pass objects by const reference, not by value. Redundant null pointer check. Prefer to initialize class members in an initialization list.

Merge request reports