Skip to content

Calo Cell children override,final un-needed virtual

LarCell/TileCell use virtual (or rm it) , override, final

  • LarCell is just a few final (so avoid virtual calls if the compiler knows the concrete type)
  • TileCell had quite a few methods that were marked virtual for no clear reason aka they do not override neither seem to get ever overriden. Beyond that we can also mark thigs as final so the compiler can avoid virtual calls if it knows the type.
  • Leave the _novirt (which are there as I guess using the "without reason" virtual ones was slow ...). In principle this we could clean up after this MR.
  • No clear why the Simul side was inheriting naively it seems to use the default setGain from CaloCell [https://acode-browser1.usatlas.bnl.gov/lxr/ident?_i=setGain]
Edited by Christos Anastopoulos

Merge request reports

Loading