TrigInDetValidation: propagate L1EM->L1eEM menu change

Hello,

As reported in ATR-27793, the TrigInDetValidation ART tests must be updated to propagate the removal of L1 EM legacy items (!63664 (merged)).

• HLT_e20_idperf_loose_lrtloose_L1EM15VH -> HLT_e20_idperf_loose_lrtloose_L1eEM18L
• HLT_e30_idperf_loose_lrtloose_L1EM22VHI -> HLT_e30_idperf_loose_lrtloose_L1eEM26M
• HLT_e26_lhtight_ivarloose_e5_idperf_loose_lrtloose_probe_L1EM22VHI -> HLT_e26_lhtight_ivarloose_e5_idperf_loose_lrtloose_probe_L1eEM26M
• HLT_e5_idperf_loose_lrtloose_probe_g25_medium_L1EM20VH -> HLT_e5_idperf_loose_lrtloose_probe_g25_medium_L1eEM24L
• HLT_e26_idperf_loose_L1EM22VHI -> HLT_e26_idperf_loose_L1eEM26M
• HLT_e26_lhtight_e14_idperf_tight_probe_50invmAB130_L1EM22VHI -> HLT_e26_lhtight_e14_idperf_tight_probe_50invmAB130_L1eEM26M
• HLT_e26_lhtight_e14_idperf_tight_nogsf_probe_50invmAB130_L1EM22VHI -> HLT_e26_lhtight_e14_idperf_tight_nogsf_probe_50invmAB130_L1eEM26M
• HLT_e26_lhtight_ivarloose_e30_lhloose_nopix_lrtmedium_probe_L1EM22VHI -> HLT_e26_lhtight_ivarloose_e30_lhloose_nopix_lrtmedium_probe_L1eEM26M
• HLT_e30_lhloose_nopix_lrtmedium_probe_g25_medium_L1EM20VH -> HLT_e30_lhloose_nopix_lrtmedium_probe_g25_medium_L1eEM24L
• HLT_e28_idperf_loose_L1EM22VHI -> HLT_e28_idperf_loose_L1eEM28M

I commented out the legacy chains, instead of removing them, for traceability. But if it is cleaner to remove them, let me know.

I also noticed a number of chains in comparitor.json that don't seem to have a eEM equivalent, maybe these are deprecated and don't exist anymore? If so, I would let experts drop the last few "L1EM" entries in a follow-up MR.

I didn't update TrigInDetAnalysisUser either (e.g. TIDAdata-chains-run3.dat).

Tagging @sutt , @keli , @adye , @hartj .

Cheers, Bertrand

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

This merge request affects 3 files:

• Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py
• Trigger/TrigValidation/TrigInDetValidation/share/TrigInDetValidation_AODtoTrkNtuple.py
• Trigger/TrigValidation/TrigInDetValidation/share/comparitor.json

Adding @sutt ,@martindl ,@hartj ,@vmartin ,@okumura ,@nagano ,@mvozak as watchers

added 23.0 Trigger review-pending-level-1 labels

looks good, thanks @martindl

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)(FullSim|Hit).*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 53786cb8)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 73581]

mentioned in merge request !64016 (merged)

To ease the review, I've submitted an identical MR at !64016 (merged) where legacy chains are removed instead of being commented out. If !64016 (merged) is preferred, I'll close this one.

Closing this one for now, assuming !64016 (merged) is just as good.

closed

mentioned in commit 89f1d45b