Skip to content

MuonAlignmentData - Revise the A&B Line handling

Johannes Junggeburth requested to merge jojungge/athena:AlignDataUpdate into 23.0

MuonAlignmentData: Clean up internal storage. Add few comments. Single Parameters & AMDB identifiers can be accessed via single methods. Switch from std::map<Identifier,ALine> to std::set<ALine> container types. Add std::cout operators to easily dump the parameters The CSCInternalParameters will be replaced in a follow-up MR.

MuonAlignmentCondAlg: Revise the access to the 4 primary alignment folders in the database. Instead of a one ReadCondHandleKey per folder, the ReadCondHandleKeyArray is used to. Parsing of external A&B lines is now possible and based on the JSON blob format as it's outlined for the COOL folders. Ensure that the methods are const to prepare reentrancy of the algorithm. In !64288 (merged), a simple alg to dump the alignment parameters into COOL will be introduced.

MuonDetDesc/MuonGeoModel: Remove internal copy of the A & B line container in the MuonDetectorManager. Remove unneccassrily complicated mechanisms to either load only certain types of alignment constants or to parse an external ascii file to overwrite the NSW alignment. If people want to test the constants, they should create a JSON file and feed it into the MuonAlignmentCondAlg.

Validation on 45k data16 events: All_quick_plots.pdf

Edited by Johannes Junggeburth

Merge request reports