Skip to content

Using MenuSequenceCAToGlobalWrapper for iso FTF and remove obsolete isobdt code

Edson Carquin Lopez requested to merge carquin/athena:23.0-tauiso-ca-mig into 23.0

Relates to ATR-27082, pinging @smwang @fpastore @jmasik

Here is the config diff I get after running test_trig_data_v1Dev_build with an without the changes in this MR.

Differences are understood, see below:

Run with arguments:
confTool.py --diff isostep/run/test_trig_data_v1Dev_build/cfg.pkl baseline/run/test_trig_data_v1Dev_build/cfg.pkl
Step 1: reference file #components: 72816
Step 2: file to check  #components: 72816
Legend:
Differences in components Settings in 1st file Settings in 2nd file
Component FastTauIsoInViews may differ
	Members =  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauIso', 'PixelRawDataProvider/TrigPixelRawDataProvidertauIso', 'SCTRawDataProvider/TrigSCTRawDataProvidertauIso', 'InDet::PixelClusterization/InDetPixelClusterizationtauIso', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauIso', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauIso', 'TrigFastTrackFinder/TrigFastTrackFinder_tauIso', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauIso', 'AthViews::ViewDataVerifier/VDVFastTauIso']  vs  ['AthViews::ViewDataVerifier/IDViewDataVerifier_tauIso', 'PixelRawDataProvider/TrigPixelRawDataProvidertauIso', 'SCTRawDataProvider/TrigSCTRawDataProvidertauIso', 'InDet::PixelClusterization/InDetPixelClusterizationtauIso', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauIso', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauIso', 'TrigFastTrackFinder/TrigFastTrackFinder_tauIso', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauIso']   <<
		>>  only in 1st file :  ['AthViews::ViewDataVerifier/VDVFastTauIso', 'AthViews::ViewDataVerifier/VDVInDetFTF_tauIso'] 
		>>  only in 2nd file :   ['AthViews::ViewDataVerifier/IDViewDataVerifier_tauIso'] 
	Sequential = False  only in 2nd file 
   3 relevant differences

The content of the ViewVerifier is the same in both cases, in the case of pure CA case this is split into two VDVs while in legacy we just use one.

Use of the Sequential setting is deprecated in CA AFAIK

Component FastTauIsoInViews_probe may differ
	Members =  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauIso', 'PixelRawDataProvider/TrigPixelRawDataProvidertauIso', 'SCTRawDataProvider/TrigSCTRawDataProvidertauIso', 'InDet::PixelClusterization/InDetPixelClusterizationtauIso', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauIso', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauIso', 'TrigFastTrackFinder/TrigFastTrackFinder_tauIso', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauIso', 'AthViews::ViewDataVerifier/VDVFastTauIso']  vs  ['AthViews::ViewDataVerifier/IDViewDataVerifier_tauIso', 'PixelRawDataProvider/TrigPixelRawDataProvidertauIso', 'SCTRawDataProvider/TrigSCTRawDataProvidertauIso', 'InDet::PixelClusterization/InDetPixelClusterizationtauIso', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauIso', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauIso', 'TrigFastTrackFinder/TrigFastTrackFinder_tauIso', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauIso']   <<
		>>  only in 1st file :  ['AthViews::ViewDataVerifier/VDVFastTauIso', 'AthViews::ViewDataVerifier/VDVInDetFTF_tauIso'] 
		>>  only in 2nd file :   ['AthViews::ViewDataVerifier/IDViewDataVerifier_tauIso'] 
	Sequential = False  only in 2nd file 
   3 relevant differences

Same as above

 Component  IDViewDataVerifier_tauIso  only in 2nd file  

Component IM_FastTauIso may differ
	InViewRoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
	RoIsLink =  initialRoI  vs  roi   <<
	Views =  FastTauIsoViews  vs  TAUFTFIsoViews   <<
	mergeUsingFeature = False  only in 1st file 
   1 relevant differences
Component IM_FastTauIso_probe may differ
	InViewRoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
	RoIsLink =  initialRoI  vs  roi   <<
	Views =  FastTauIsoViews_probe  vs  TAUFTFIsoViews_probe   <<
	mergeUsingFeature = False  only in 1st file 
   1 relevant differences

mergeUsingFeature = False is already the default in legacy, not sure why this is not reflected in the configuration (maybe because this default is set in the C++)

Component InDetPixelClusterizationtauIso may differ
	RoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
   but all are suppressed by renaming/known differences/...
Component InDetSCTClusterizationtauIso may differ
	RoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
   but all are suppressed by renaming/known differences/...

 Component  TrackRoiUpdaterBDT  only in 2nd file  
Component TrigFastTrackFinder_tauIso may differ
	RoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
   but all are suppressed by renaming/known differences/...
Component TrigPixelRawDataProvidertauIso may differ
	RoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
   but all are suppressed by renaming/known differences/...
Component TrigSCTRawDataProvidertauIso may differ
	RoIs =  FastTauIsoRoIs  vs  RoiForTauIso   <<
   but all are suppressed by renaming/known differences/...

 Component VDVFastTauIso only in 1st file  


 Component VDVInDetFTF_tauIso only in 1st file

BDT Iso algorithms are being removed and the rest refers to the VDV which is mentioned above


Component tauFastTrackCoreInViews may differ
	Members =  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauCore', 'PixelRawDataProvider/TrigPixelRawDataProvidertauCore', 'SCTRawDataProvider/TrigSCTRawDataProvidertauCore', 'InDet::PixelClusterization/InDetPixelClusterizationtauCore', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauCore', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauCore', 'TrigFastTrackFinder/TrigFastTrackFinder_tauCore', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauCore', 'AthViews::ViewDataVerifier/VDVFastTauCore', 'TrigTauTrackRoiUpdater/TrackRoiUpdater']  vs  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauCore', 'PixelRawDataProvider/TrigPixelRawDataProvidertauCore', 'SCTRawDataProvider/TrigSCTRawDataProvidertauCore', 'InDet::PixelClusterization/InDetPixelClusterizationtauCore', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauCore', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauCore', 'TrigFastTrackFinder/TrigFastTrackFinder_tauCore', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauCore', 'AthViews::ViewDataVerifier/VDVFastTauCore', 'TrigTauTrackRoiUpdater/TrackRoiUpdater', 'TrigTauTrackRoiUpdater/TrackRoiUpdaterBDT']   <<
		>>  only in 2nd file :   ['TrigTauTrackRoiUpdater/TrackRoiUpdaterBDT'] 
   1 relevant differences
Component tauFastTrackCoreInViews_probe may differ
	Members =  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauCore', 'PixelRawDataProvider/TrigPixelRawDataProvidertauCore', 'SCTRawDataProvider/TrigSCTRawDataProvidertauCore', 'InDet::PixelClusterization/InDetPixelClusterizationtauCore', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauCore', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauCore', 'TrigFastTrackFinder/TrigFastTrackFinder_tauCore', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauCore', 'AthViews::ViewDataVerifier/VDVFastTauCore', 'TrigTauTrackRoiUpdater/TrackRoiUpdater']  vs  ['AthViews::ViewDataVerifier/VDVInDetFTF_tauCore', 'PixelRawDataProvider/TrigPixelRawDataProvidertauCore', 'SCTRawDataProvider/TrigSCTRawDataProvidertauCore', 'InDet::PixelClusterization/InDetPixelClusterizationtauCore', 'InDet::SCT_Clusterization/InDetSCTClusterizationtauCore', 'InDet::SiTrackerSpacePointFinder/TrigSpacePointFindertauCore', 'TrigFastTrackFinder/TrigFastTrackFinder_tauCore', 'InDet::TrigTrackingxAODCnvMT/InDetTrigTrackParticleCreatorAlgtauCore', 'AthViews::ViewDataVerifier/VDVFastTauCore', 'TrigTauTrackRoiUpdater/TrackRoiUpdater', 'TrigTauTrackRoiUpdater/TrackRoiUpdaterBDT']   <<
		>>  only in 2nd file :   ['TrigTauTrackRoiUpdater/TrackRoiUpdaterBDT'] 
   1 relevant differences
Component tauIsoFTF may differ
	ModeOR = False  only in 2nd file 
   1 relevant differences
Component tauIsoFTF_probe may differ
	ExtraDataForDynamicConsumers =  []  vs  ()   <<
	ExtraInputs =  []  vs  ()   <<
	ExtraOutputs =  []  vs  ()   <<
	ModeOR = False  only in 2nd file 
	NeededResources =  []  vs  ()   <<
   1 relevant differences

ModeOR seems deprecated in CA, the other changes refer to replacing lists with tuples

Edited by Edson Carquin Lopez

Merge request reports