Skip to content

Simplify TrackFindingAlg

Tim Adye requested to merge adye/athena:adye-ckf21 into main

Follow-up to !64606 (merged) to simplify the TrackFindingAlg.

  • separate DuplicateSeedDetector from TrackFindingMeasurements (renamed from Measurements).
  • TrackFindingMeasurements can now be forward-declared as a simple class in TrackFindingAlg.h. No (virtual) inheritance needed.
  • construct TrackFindingMeasurements and DuplicateSeedDetector directly in TrackFindingAlg::execute as stack variables. No need for TrackFindingAlg::initMeasurements and unique_ptr.
  • don't keep sourceLinkVec unless needed by TrackStatePrinter in TrackFindingMeasurements::addMeasurements.
  • better way to enable tools from @cvarni.
  • ATLASUncalibSourceLinkElementsName now has to be enabled. Otherwise, downstream, this would cause deallocated memory accesses to the source links.
  • Check for errors with WriteHandle::isValid().
Edited by Tim Adye

Merge request reports