migration of TrigValidTool and reducing some log output

ZdcTrigValidTool is now (not "not") moved into ZdcAnalysis (from its own package) and run by default in the Run 3 CA config.

Also, some log output from the ZDC signal processing is suppressed by moving it from Info to Debug.

This merge request affects 3 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid

Affected files list will not be printed in this case

added 23.0 ForwardDetectors Trigger analysis-review-required review-pending-level-1 labels

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash b3c3a193)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76450]

Hi @steinber. There are some compilation errors here like the following:

In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/23.0/ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcTrigValidTool.cxx:5:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/23.0/ForwardDetectors/ZDC/ZdcAnalysis/ZdcAnalysis/ZdcTrigValidTool.h:19:10: fatal error: ZdcUtils/ZDCTriggerSim.h: No such file or directory
   19 | #include "ZdcUtils/ZDCTriggerSim.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Can these be looked into?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

jenkins please retry a build

This merge request affects 3 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash b3c3a193)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76486]

added 1 commit

• e41e5e76 - added some libraries needed by ZdcTrigValid to CMakeLists

Compare with previous version

This merge request affects 3 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid

Affected files list will not be printed in this case

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash e41e5e76)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76499]

Hmm; strange. Not sure what's happening but still compilation errors. Switching tags while the investigations are ongoing.

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

added 2 commits

• 5fbe8098 - removed old ZdcTrigValidTool code, moved to ZdcAnalysis
• 93320795 - removed old ZdcTrigValidTool CMakeFiles.txt

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-user-action-required label

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

Hi @jbeacham - i'm trying everything I can and I can't figure out why this is not building on gitlab, when it's building just fine locally. It's probably something to do with trying to remove ZdcTrigValid (so I removed those source files to avoid any possible conflict), but is there a way to escalate this to get some further assistance?

CI Result FAILURE (hash 93320795)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76562]

Hi

There are kind of 2 issues I guess

For Athena the original issue was like :

 m_zdcModuleMaxADC.initialize();
-->
ATH_CHECK(m_zdcModuleMaxADC.initialize());

But then you rm (in the last 10 hours) one CMakeLists which means also it can not figure headers.

More or less I think for the Athena part you kind of needed things like the above.

2. For the Analysis part that I think created the confusion but should be different.

ZDCUtils is not here https://gitlab.cern.ch/atlas/athena/-/blob/main/Projects/AnalysisBase/package_filters.txt or here https://gitlab.cern.ch/atlas/athena/-/blob/main/Projects/AthAnalysis/package_filters.txt I just see

+ ForwardDetectors/ZDC/ZdcAnalysis

Not sure if you tried analysis base compilation locally. But is not obvious how it can find the ZDCUtils . In your local build could have compiled for Analysis releases because you added them in your package_filters but would not know 100%

In anycase, for this I think the real question is if ZdcUtils should be added in Analysis Releases. If ZDCAnalysis has to depends on it prb yes I assume. But there are questions on if what elese it will bring etc. So this is for AMG. But let me just ping @akraszna and @krumnack .

Thanks @christos - All I saw before was the missing header, which sounds trivially explained by the missing package in the filters. Presumably before the original package simply wasn’t being built. This tool is useful to us for reconstruction, especially during commissioning where we would like it in several context, so I would appreciate including ZdcUtils if at all possible.

To explain the missing files, I moved the tool into ZdcAnalysis to avoid fragmenting our code across too many packages (to avoid future problems like this). I removed the duplicates to avoid confusion later.

Hey

I would try 1st to fix the

Athena: number of compilation errors 1, warnings 1

these have changed over the CI runs. But are not related to

`#include "ZdcUtils/ZDCTriggerSim.h"`

Then for these 2

AnalysisBase: number of compilation errors 1, warnings 0

AthAnalysis: number of compilation errors 1, warnings 0

These indeed are both related to

`#include "ZdcUtils/ZDCTriggerSim.h"`

and due to ZdcUtils not in any of the 2 releases .

Hi @christos - Indeed that was related to a different missing file. Sorry I missed that, and fixing now.

For the other 2 if you need ZDCUtils for these

it might worth to add the package to these 2 as part of this MR

https://gitlab.cern.ch/atlas/athena/-/blob/main/Projects/AnalysisBase/package_filters.txt

and

https://gitlab.cern.ch/atlas/athena/-/blob/main/Projects/AthAnalysis/package_filters.txt

i.e you need to (And you can in principle ) modify these 2 files as part of the MR

Yes - I thought I had already added those to the MR, but somehow it didn’t make it.

added 3 commits

• 5e870cae - removed obsolete tool includes, and only using interface now
• 9675b48d - restored Run 2 raw sample functionality, but run 2 and 3 need a proper flag
• 9099523e - added ZdcUtils to AnalysisBase and AthAnalysis, to support ZdcAnalysis

Compare with previous version

This merge request affects 6 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid
• Projects/AnalysisBase
• Projects/AthAnalysis

Affected files list will not be printed in this case

Adding @krumnack ,@akraszna ,@rbianchi as watchers

added Build label

CI integration tests for projects Athena,AnalysisBase are cancelled because of compilation error(s)

CI Result FAILURE (hash 9099523e)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76587]

added 2 commits

• 405f50bf - fix compilation error for AnalysisBase
• fe4a855a - fix compilation error for Athena

Compare with previous version

This merge request affects 6 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid
• Projects/AnalysisBase
• Projects/AthAnalysis

Affected files list will not be printed in this case

Adding @krumnack ,@akraszna ,@rbianchi as watchers

resolved all threads

CI Result SUCCESS (hash fe4a855a)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76589]

The changes look okay and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

added review-approved-tier0 label

changed the description

Hi @jmaurer - I thought things had converged on this MR -- will it get merged today? Thanks!

resolved all threads

resolved all threads

added 73 commits

• fe4a855a...efe1b0fe - 72 commits from branch atlas:23.0
• d3c37f9a - Resolving conflicts from LED tool merge

Compare with previous version

This merge request affects 6 packages:

• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple
• ForwardDetectors/ZDC/ZdcRec
• ForwardDetectors/ZDC/ZdcTrigValid
• Projects/AnalysisBase
• Projects/AthAnalysis

Affected files list will not be printed in this case

Adding @krumnack ,@akraszna ,@rbianchi as watchers