DerivationFrameworkCalo: Fix cppcheck warning.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.DerivationFrameworkCalo-20230826 into main

Prefer pre-increment to post-increment for iterator classes.

Merge request reports