Skip to content

Ppr/PPM/CPMMonitoring: Fix wrong variable type for event numbers and bug related to mismatch-event-counter

Sebastian Mario Weber requested to merge smweber/athena:fixEventNumberType into 23.0

The event number variable used in the Ppr-,PPM, and CPM-Monitoring was inialized as integer, whereas it should be long long. This lead to negative event numbers (2-complement) or none at all.

The second bug that is fixed is related the mismatch event counter. The number of events with simulation mismatches which are dumped in the monitoring is limited to 10 events per lb. Due to a bug in the code the counter that tracks this was incremented for each event, not only for each event with an actual mismatch.

The first bug was fixed by changing the type, the second fix moves the counter incrementation to the correct scope.

Merge request reports