Skip to content

Draft: Main check reference surface

Edward Moyse requested to merge emoyse/athena:main-checkrefsurface into main

In the current Athena implementation this:

  BOOST_CHECK_EQUAL(ts.hasReferenceSurface(), false); //This currently returns true (!)
  ts.setReferenceSurface(pc.predicted.referenceSurface().getSharedPtr());

throws an exception.

I attempted to fix this by removing this throw, and instead returning nullptr. But now, hasReferenceSurface returns true... which is a bit confusing (and hence this being draft)

Edit: forgot to link the issue I made in ACTS itself: https://github.com/acts-project/acts/issues/2456

cc @tbold @wolter @pagessin

Edited by Edward Moyse

Merge request reports

Loading