use summaryValueInt/Float methods in egamma

added Egamma Reconstruction Tracking main labels

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• Event/xAOD/xAODTracking
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaTools

Affected files list will not be printed in this case

Adding @toyamaza ,@tbold ,@akraszna ,@goetz as watchers

added EDM analysis-review-required labels

CI Result SUCCESS (hash c7feeaa2)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78670]

removed analysis-review-required label

added 3 commits

• 556f2809 - Templatise summaryValue method.
• 2b300f3f - Templatise summaryValueOr method.
• 73b576e2 - Replace summaryValueInt and Float with template summaryValueOr method.

Compare with previous version

Jenkins please retry a build

This merge request affects 5 packages:

• Event/xAOD/xAODEgamma
• Event/xAOD/xAODTracking
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaTools
• Reconstruction/egamma/egammaValidation

Affected files list will not be printed in this case

Adding @toyamaza ,@tbold ,@akraszna ,@goetz as watchers

added analysis-review-required label

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 73b576e2)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78689]

Hi @llewitt touching xAOD interfaces can be tricky. The usage of these is not only in the repo but can be any analysis anywhere.

More or less except if there is clear gain, lets avoid removing etc

Can we not just use the summaryValueFloat summaryValueInt in the egamma code?

the egamma helpers?

So

• I would not delete public xAOD methods, is hard to know where they could be used, outside the repo in any analysis code.

• Yes direct return from Tracking would be nice but this needs discussion with tracking ...

• xAOD public API can be tricky

Can you not just use the EgammaHelpers:: to do what you try?

closed

reopened

Jenkins please retry a build

This merge request affects 1 package:

• Reconstruction/egamma/egammaTools

This merge request affects 1 file:

• Reconstruction/egamma/egammaTools/src/EMTrackMatchBuilder.cxx

Adding @goetz as watcher

removed analysis-review-required label

removed EDM label

removed Tracking label

The system selected 49 tests to probe the Athena changeset (out of 73 available tests). Link to tests selection rules

CI Result SUCCESS (hash 3866ff42)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78726]

resolved all threads

added 3 commits

• 35f7b66a - Use summaryValueInt in EMBremCollectionBuilder.
• edc7a9cf - Use summaryValueInt in egammaSelectedTrackCopy.
• 9b9d5177 - Use summaryValueInt in electronSuperClusterBuilder.

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaTools

Affected files list will not be printed in this case

Adding @goetz as watcher

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 9b9d5177)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 78730]

resolved all threads

added 1 commit

• cb718947 - Fix typos. Revert to prior copySummaryValue implementation.

Compare with previous version

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaTools

Affected files list will not be printed in this case

Adding @goetz as watcher