Skip to content

Ensure thread-safe deep copies of FlowElements

Vilius Cepaitis requested to merge vcepaiti/athena:thread-safe-neutrals-deep-copy into main

This is a bugfix to restore thread-safety when deep copying FlowElements, which occasionally causes std::bad_array_new_length exceptions if a deep copy is performed before a decoration has been applied.

The MR contains two major changes:

  • Neutral PFO copies are reverted to shallow copies by default. This should be a simple fix for the vast majority of use cases
  • For the specific case of by-vertex jet reconstructions, a dummy ReadDecorHandleKeyArray is added to schedule the JetConstituentModSequence algorithm after all the decorations on PFOs have been performed

Addressing MR: !65105 (merged) Fixing issue: ATLASRECTS-7764

Edited by Vilius Cepaitis

Merge request reports