Skip to content

Speedup and cleanup of LArDigitalTriggMonAlg

Walter Lampl requested to merge wlampl/athena:LArDigTriggMonCleanup1 into main

As reported in ATLASRECTS-7798, the monitoring algorithm LArDigitalTriggMonAlg is horribly slow. This MR brings the execution speed down to about 100ms/event, mostly because the call to fill was pulled out of a tight loop over all supercells

On top of the speedup, the code was streamlined and lots of dead/unnecessary code was removed.

I expect the histogram output to change because the current version had at least two obvious bugs:

  • The event-size counter started with -1 instead of 0
  • The LArOnlineID helper class (for regular readout) was used instead of the LArOnline_SuperCellID helper

There are a few more suspicous details we should address, therefore this MR remains a draft for now.

cc @ekay

Merge request reports